Initial module for aws_kms_key #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ben-vaughan-nttd
commented
Oct 27, 2025
ben-vaughan-nttd
commented
- Include test with inline policy
- Supports all major aws_kms_key resource features in v5.x of the provider
* Include test with inline policy * Supports all major aws_kms_key resource features in v5.x of the provider
ben-vaughan-nttd
requested review from
aarti-joshi-nttd,
chris11-taylor-nttd,
debasish-sahoo-nttd,
kevin11-allen-nttd,
sean-dowd-nttd and
sean-fairchild-nttd
…abeling, and Terraform checks
|
Tip This is your first PR, and it will be labeled as a If you need to change this because you have existing tags, manually remove the label and apply the appropriate one ( |
Signed-off-by: Aarti Joshi <[email protected]>
aarti-joshi-nttd
approved these changes
Oct 29, 2025
Contributor
aarti-joshi-nttd
left a comment
aarti-joshi-nttd
left a comment
There was a problem hiding this comment.
FYI...Fixed a formatting change with a commit. Approving this!!
debasish-sahoo-nttd
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.